-
Notifications
You must be signed in to change notification settings - Fork 298
Reviving some functionality #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JegernOUTT
wants to merge
19
commits into
main
Choose a base branch
from
new-models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,833
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `line1` and `line2` assignments to begin at 1 instead of 0 - Add defensive checks for line numbers exceeding file content length - Modify debug logging to reflect updated line numbers - Refactor tests and examples for consistent use of 1-based indexing
Convert HashMap to AHashMap using .into_iter().collect() to match the expected type for tokenizers::WordPiece::builder().vocab(). This fixes compilation error E0277.
Use .into() to let the compiler convert the array into the appropriate type (HashMap for local tokenizers 0.21.1, AHashMap for CI tokenizers 0.21.4). This ensures compatibility across different tokenizers versions.
- Update tokenizers from 0.21.1 to 0.21.4 to match CI version - Simplify vocab initialization using array literal without .into() - This ensures consistent behavior across all build environments
- Normalize CRLF to LF in all parser tests before parsing - This ensures consistent byte offsets across Windows and Unix platforms - Fixes test failures in test_kotlin_main and test_kotlin_person on Windows - The issue was that reference JSON files use LF-based byte offsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.